Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenZFS 6872 - zfs libraries should not allow uninitialized variables #5640

Merged
merged 1 commit into from
Jan 24, 2017

Conversation

gmelikov
Copy link
Member

@gmelikov gmelikov commented Jan 23, 2017

Authored by: Paul Dagnelie pcd@delphix.com
Reviewed by: Dan Kimmel dan.kimmel@delphix.com
Reviewed by: George Wilson george.wilson@delphix.com
Reviewed by: Prakash Surya prakash.surya@delphix.com
Reviewed by: Yuri Pankov yuri.pankov@nexenta.com
Approved by: Robert Mustacchi rm@joyent.com
Ported-by: George Melikov mail@gmelikov.ru

OpenZFS-issue: https://www.illumos.org/issues/6872
OpenZFS-commit: openzfs/openzfs@f83b46b

Porting notes:
Many changes were already made in ZoL (for ex. in d4ed667).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)

@mention-bot
Copy link

@gmelikov, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ryao, @behlendorf and @mkjorling to be potential reviewers.

Authored by: Paul Dagnelie <pcd@delphix.com>
Reviewed by: Dan Kimmel <dan.kimmel@delphix.com>
Reviewed by: George Wilson <george.wilson@delphix.com>
Reviewed by: Prakash Surya <prakash.surya@delphix.com>
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Approved by: Robert Mustacchi <rm@joyent.com>
Ported-by: George Melikov <mail@gmelikov.ru>

OpenZFS-issue: https://www.illumos.org/issues/6872
OpenZFS-commit: openzfs/openzfs@f83b46b

Porting notes:
Many changes were already made in ZoL (for ex. in d4ed667).
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I verified that all but this one change we're already applied to ZoL.

@behlendorf behlendorf merged commit 935550f into openzfs:master Jan 24, 2017
wli5 pushed a commit to wli5/zfs that referenced this pull request Feb 28, 2017
Porting notes:
- Many changes were already made in ZoL (for ex. in d4ed667).

Authored by: Paul Dagnelie <pcd@delphix.com>
Reviewed by: Dan Kimmel <dan.kimmel@delphix.com>
Reviewed by: George Wilson <george.wilson@delphix.com>
Reviewed by: Prakash Surya <prakash.surya@delphix.com>
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Approved by: Robert Mustacchi <rm@joyent.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Ported-by: George Melikov <mail@gmelikov.ru>

OpenZFS-issue: https://www.illumos.org/issues/6872
OpenZFS-commit: openzfs/openzfs@f83b46b
Closes openzfs#5640
wli5 pushed a commit to wli5/zfs that referenced this pull request Feb 28, 2017
Porting notes:
- Many changes were already made in ZoL (for ex. in d4ed667).

Authored by: Paul Dagnelie <pcd@delphix.com>
Reviewed by: Dan Kimmel <dan.kimmel@delphix.com>
Reviewed by: George Wilson <george.wilson@delphix.com>
Reviewed by: Prakash Surya <prakash.surya@delphix.com>
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Approved by: Robert Mustacchi <rm@joyent.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Ported-by: George Melikov <mail@gmelikov.ru>

OpenZFS-issue: https://www.illumos.org/issues/6872
OpenZFS-commit: openzfs/openzfs@f83b46b
Closes openzfs#5640
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants