zfs: missing newline character in zfs_do_channel_program() error message #8783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit simply adds a missing newline ("\n") character to the error
message printed by the zfs command when the provided pool parameter
can't be found.
Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
dinatale2
approved these changes
May 22, 2019
Codecov Report
@@ Coverage Diff @@
## master #8783 +/- ##
==========================================
+ Coverage 78.63% 78.68% +0.04%
==========================================
Files 381 381
Lines 117798 117797 -1
==========================================
+ Hits 92636 92686 +50
+ Misses 25162 25111 -51
Continue to review full report at Codecov.
|
chrisrd
approved these changes
May 22, 2019
ikozhukhov
approved these changes
May 22, 2019
gmelikov
approved these changes
May 22, 2019
behlendorf
added
Status: Accepted
behlendorf
pushed a commit
that referenced
this pull request
Jun 7, 2019
This commit simply adds a missing newline ("\n") character to the error
message printed by the zfs command when the provided pool parameter
can't be found.
Reviewed-by: Chris Dunlop <chris@onthe.net.au>
Reviewed-by: Giuseppe Di Natale <guss80@gmail.com>
Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
Closes #8783
allanjude
pushed a commit
to allanjude/zfs
that referenced
this pull request
Jun 7, 2019
This commit simply adds a missing newline ("\n") character to the error
message printed by the zfs command when the provided pool parameter
can't be found.
Reviewed-by: Chris Dunlop <chris@onthe.net.au>
Reviewed-by: Giuseppe Di Natale <guss80@gmail.com>
Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
Closes openzfs#8783
allanjude
pushed a commit
to allanjude/zfs
that referenced
this pull request
Jun 15, 2019
This commit simply adds a missing newline ("\n") character to the error
message printed by the zfs command when the provided pool parameter
can't be found.
Reviewed-by: Chris Dunlop <chris@onthe.net.au>
Reviewed-by: Giuseppe Di Natale <guss80@gmail.com>
Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
Closes openzfs#8783
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Wrong error format (missing a newline) when no pool is available running
zfs programDescription
This commit simply adds a missing newline ("\n") character to the error message printed by the zfs command when the provided pool parameter can't be found.
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.