Fix incorrect error message for raw receive #8863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes an incorrect error message that comes up when doing a non-forcing, raw, incremental receive into a dataset that has a newer snapshot than the "from" snapshot. In this case, the current code prints a confusing message about an IVset guid mismatch. This functionality is supported by non-raw receives as an undocumented feature, but was never supported by the raw receive code. If this is desired in the future, we can probably figure out a way to make it work. Signed-off-by: Tom Caputi <tcaputi@datto.com>
behlendorf
changed the title
does that mean that it will never work that way again? |
Codecov Report
@@ Coverage Diff @@
## master #8863 +/- ##
==========================================
+ Coverage 78.68% 78.87% +0.19%
==========================================
Files 382 382
Lines 117771 117774 +3
==========================================
+ Hits 92672 92900 +228
+ Misses 25099 24874 -225
Continue to review full report at Codecov.
|
|
We can probably make this work at some point in the future if we want. Doing that will require more investigation though and we've decided not to prioritize it at the moment. The fix here is easy to reason about and (at least) communicates to the end user how they can solve the problem. |
behlendorf
approved these changes
Jun 7, 2019
ahrens
approved these changes
Jun 10, 2019
behlendorf
added
Status: Accepted
behlendorf
pushed a commit
that referenced
this pull request
Jun 11, 2019
This patch fixes an incorrect error message that comes up when doing a non-forcing, raw, incremental receive into a dataset that has a newer snapshot than the "from" snapshot. In this case, the current code prints a confusing message about an IVset guid mismatch. This functionality is supported by non-raw receives as an undocumented feature, but was never supported by the raw receive code. If this is desired in the future, we can probably figure out a way to make it work. Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Signed-off-by: Tom Caputi <tcaputi@datto.com> Issue #8758 Closes #8863
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes an incorrect error message that comes up when
doing a non-forcing, raw, incremental receive into a dataset
that has a newer snapshot than the "from" snapshot. In this
case, the current code prints a confusing message about an IVset
guid mismatch.
This functionality is supported by non-raw receives as an
undocumented feature, but was never supported by the raw receive
code. If this is desired in the future, we can probably figure
out a way to make it work.
Signed-off-by: Tom Caputi tcaputi@datto.com
Motivation and Context
#8758
We decided that it would be more difficult than it is worth to make this feature work for raw sends. This code simply makes the error message consistent.
Types of changes
Checklist:
Signed-off-by.