Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix memory leak #8911

Merged
merged 1 commit into from
Jun 19, 2019
Merged

fix memory leak #8911

merged 1 commit into from
Jun 19, 2019

Conversation

c0d3z3r0
Copy link
Contributor

@c0d3z3r0 c0d3z3r0 commented Jun 15, 2019 •
edited
Loading

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@c0d3z3r0
fix memory leak
1f58e47 
Signed-off-by: Michael Niewöhner <foss@mniewoehner.de>
@c0d3z3r0 c0d3z3r0 force-pushed the for-upstream/fix_vdev_memory_leak branch from 90b3007 to 1f58e47 Compare June 15, 2019 22:10
@c0d3z3r0 c0d3z3r0 mentioned this pull request Jun 15, 2019
Closed
@codecov
Copy link

codecov bot commented Jun 16, 2019 •
edited
Loading

Codecov Report

Merging #8911 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8911      +/-   ##
==========================================
- Coverage   78.66%   78.65%   -0.01%     
==========================================
  Files         382      382              
  Lines      117840   117841       +1     
==========================================
- Hits        92698    92687      -11     
- Misses      25142    25154      +12
Flag Coverage Δ
#kernel 79.26% <ø> (-0.03%) ⬇️
#user 67.23% <100%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1b5801...1f58e47. Read the comment docs.

tonyhutter
tonyhutter approved these changes Jun 17, 2019
View reviewed changes
Copy link
Contributor

@tonyhutter tonyhutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Jun 19, 2019
@behlendorf behlendorf merged commit 0b755ec into openzfs:master Jun 19, 2019
@c0d3z3r0 c0d3z3r0 deleted the for-upstream/fix_vdev_memory_leak branch June 22, 2019 22:25
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 13, 2019
@c0d3z3r0 @tonyhutter
Fix memory leak in check_disk()
f7b1688 
Reviewed-by: Allan Jude <allanjude@freebsd.org>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Signed-off-by: Michael Niewöhner <foss@mniewoehner.de>
Closes openzfs#8897
Closes openzfs#8911
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 22, 2019
@c0d3z3r0 @tonyhutter
Fix memory leak in check_disk()
a79022a 
Reviewed-by: Allan Jude <allanjude@freebsd.org>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Signed-off-by: Michael Niewöhner <foss@mniewoehner.de>
Closes openzfs#8897
Closes openzfs#8911
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 23, 2019
@c0d3z3r0 @tonyhutter
Fix memory leak in check_disk()
0042214 
Reviewed-by: Allan Jude <allanjude@freebsd.org>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Signed-off-by: Michael Niewöhner <foss@mniewoehner.de>
Closes openzfs#8897
Closes openzfs#8911
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 17, 2019
@c0d3z3r0 @tonyhutter
Fix memory leak in check_disk()
0a39fda 
Reviewed-by: Allan Jude <allanjude@freebsd.org>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Signed-off-by: Michael Niewöhner <foss@mniewoehner.de>
Closes openzfs#8897
Closes openzfs#8911
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 18, 2019
@c0d3z3r0 @tonyhutter
Fix memory leak in check_disk()
593b99d 
Reviewed-by: Allan Jude <allanjude@freebsd.org>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Signed-off-by: Michael Niewöhner <foss@mniewoehner.de>
Closes openzfs#8897
Closes openzfs#8911
tonyhutter pushed a commit that referenced this pull request Sep 26, 2019
@c0d3z3r0 @tonyhutter
Fix memory leak in check_disk()
2087b6c 
Reviewed-by: Allan Jude <allanjude@freebsd.org>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Signed-off-by: Michael Niewöhner <foss@mniewoehner.de>
Closes #8897
Closes #8911
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardelling richardelling richardelling approved these changes

@allanjude allanjude allanjude approved these changes

@tonyhutter tonyhutter tonyhutter approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@c0d3z3r0 @richardelling @allanjude @tonyhutter @behlendorf