Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test compile with libzim using ICU 73.2 #63

Closed
wants to merge 2 commits into from

Conversation

Jaifroid
Copy link
Collaborator

@Jaifroid Jaifroid commented Oct 25, 2023

Do not merge. Test code only.

Force push to remove the test build from PR history before closing PR. DONE

@Jaifroid Jaifroid added build Code relating to building or publishing assets tests labels Oct 25, 2023
@Jaifroid Jaifroid self-assigned this Oct 25, 2023
@Jaifroid
Copy link
Collaborator Author

First failure expected -- because testing released version, not the new binary.

@Jaifroid
Copy link
Collaborator Author

@Jaifroid Jaifroid force-pushed the Test-compile-with-libzim-using-ICU-71.1 branch from 3e7118b to 128c98c Compare October 25, 2023 20:33
@Jaifroid
Copy link
Collaborator Author

And now passing when building as a release (instead of as nightly) -- see https://github.com/openzim/javascript-libzim/actions/runs/6645850689.

@Jaifroid Jaifroid marked this pull request as ready for review October 25, 2023 20:38
@Jaifroid Jaifroid marked this pull request as draft October 25, 2023 20:39
@Jaifroid Jaifroid changed the title Test compile with libzim using ICU 71.1 Test compile with libzim using ICU 73.2 Nov 2, 2023
@Jaifroid Jaifroid closed this Nov 18, 2023
@Jaifroid Jaifroid deleted the Test-compile-with-libzim-using-ICU-71.1 branch November 18, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Code relating to building or publishing assets tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant