Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fulltext indexing code should be moved from zimwriterfs to zimlib #12

Closed
kelson42 opened this issue Apr 16, 2017 · 2 comments
Closed

Fulltext indexing code should be moved from zimwriterfs to zimlib #12

kelson42 opened this issue Apr 16, 2017 · 2 comments
Assignees
@mgautierfr
Labels
enhancement

Comments

@kelson42
Copy link
Contributor

I was kind of surprised this has not been moved to the libzim!
@kelson42 kelson42 mentioned this issue Apr 16, 2017
Closed
@mgautierfr
Copy link
Collaborator

Yes, I've only moved the search part in libzim.

But yes, the fulltext indexing part have to move into the libzim. Still some work to do.

@kelson42 kelson42 changed the title Fulltext indexing code seems to be still in zimwriterfs Fulltext indexing code should be moved from zimwriterfs to zimlib Jun 10, 2017
@kelson42
Copy link
Contributor Author

Otherwise it's impossible to use the libzim to create ZIM files with ft index. This is important for the hackathon of this summer to allow node-libzim to create this kind of file.

@kelson42 kelson42 reopened this Jun 10, 2017
@kelson42 kelson42 mentioned this issue Jan 31, 2018
Closed
mgautierfr added a commit that referenced this issue May 9, 2018
@mgautierfr
Move xapian indexer in libzim from zimwriterfs.
d1f07c7 
xapian database is a base libzim functionnality. The indexing part
should be in libzim.

This is mainly a recopy of code already in zimwriterfs in libzim.

The tools.cpp include the standard <dirent.h> header and it conflicts
with our "dirent.h".
To resolve the conflict, I've renamed dirent.h into _dirent.h.
As it is a private header, there is no problem :)

Fix #12
mgautierfr added a commit that referenced this issue May 9, 2018
@mgautierfr
Move xapian indexer in libzim from zimwriterfs.
f4e0f1f 
xapian database is a base libzim functionnality. The indexing part
should be in libzim.

This is mainly a recopy of code already in zimwriterfs in libzim.

The tools.cpp include the standard <dirent.h> header and it conflicts
with our "dirent.h".
To resolve the conflict, I've renamed dirent.h into _dirent.h.
As it is a private header, there is no problem :)

Fix #12
mgautierfr added a commit that referenced this issue May 9, 2018
@mgautierfr
Move xapian indexer in libzim from zimwriterfs.
caacd4f 
xapian database is a base libzim functionnality. The indexing part
should be in libzim.

This is mainly a recopy of code already in zimwriterfs in libzim.

The tools.cpp include the standard <dirent.h> header and it conflicts
with our "dirent.h".
To resolve the conflict, I've renamed dirent.h into _dirent.h.
As it is a private header, there is no problem :)

Fix #12
mgautierfr added a commit that referenced this issue May 9, 2018
@mgautierfr
Move xapian indexer in libzim from zimwriterfs.
b23b0c9 
xapian database is a base libzim functionnality. The indexing part
should be in libzim.

This is mainly a recopy of code already in zimwriterfs in libzim.

The tools.cpp include the standard <dirent.h> header and it conflicts
with our "dirent.h".
To resolve the conflict, I've renamed dirent.h into _dirent.h.
As it is a private header, there is no problem :)

Fix #12
mgautierfr added a commit that referenced this issue May 9, 2018
@mgautierfr
Move xapian indexer in libzim from zimwriterfs.
fa638f0 
xapian database is a base libzim functionnality. The indexing part
should be in libzim.

This is mainly a recopy of code already in zimwriterfs in libzim.

The tools.cpp include the standard <dirent.h> header and it conflicts
with our "dirent.h".
To resolve the conflict, I've renamed dirent.h into _dirent.h.
As it is a private header, there is no problem :)

Fix #12
@ghost ghost mentioned this issue Apr 27, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgautierfr mgautierfr

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mgautierfr @kelson42