Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for duplicate logs. #84

Merged
merged 2 commits into from
Aug 24, 2019
Merged

Fix for duplicate logs. #84

merged 2 commits into from
Aug 24, 2019

Conversation

audiodude
Copy link
Member

Fixes #83

This bug was introduced when we switched from doing unseen articles after each quality/importance run, to doing them all at the end. Because of that, the old_rating doesn't get updated in between runs. So, when a new article appears that has both a quality and an importance rating, the rating for quality would be written, then it would be re-written with importance as a "new" rating, which would set the quality to NULL.

This manifests as duplicate logs because the next day, the old_rating is there, but has quality NotA-Class, so we write a log that the quality went from NotA-Class -> Whatever, which shows up in the logs as "assessed".

@codecov
Copy link

codecov bot commented Aug 24, 2019

Codecov Report

Merging #84 into master will increase coverage by 0.01%.
The diff coverage is 97.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
+ Coverage   95.47%   95.49%   +0.01%     
==========================================
  Files          31       31              
  Lines        1924     1952      +28     
==========================================
+ Hits         1837     1864      +27     
- Misses         87       88       +1
Impacted Files Coverage Δ
wp1/logic/project.py 87.26% <100%> (ø) ⬆️
wp1/logic/project_test.py 98.65% <100%> (+0.06%) ⬆️
wp1/logic/rating.py 97.1% <90%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1c73a3...3d689cb. Read the comment docs.

@audiodude audiodude merged commit e92ee79 into master Aug 24, 2019
@kelson42 kelson42 deleted the duplicate-logs branch August 25, 2019 05:11
audiodude added a commit that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate logs when adding a new rating
1 participant