-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to seek on apple browsers #91
Comments
@rgaudin I can confirm that this is an issue with ogvjs. We can actually reproduce this on other platforms than Apple by simply changing the |
OK I'm leaving this open but categorizing it as awaiting-upstream. |
@rgaudin @satyamtg I would check again this with http://library.kiwix.org/mali-pour-les-nuls_fr_all_2020-04 because we have now there a kiwix-serve which should support byte-range requests properly. |
No improvement using
if (this._stream && !this._stream.seekable)
throw new Error("Cannot seek a non-seekable stream");
--
seekable: {
get: function get() {
return this.demuxer.seekable
}
}, The ogv.js readme: clearly states that this should work with Range header. Actually, when testing the build folder of the zim file outside kiwix-serve, it seeks as expected. It's hard to debug what happens with the devtools but it seems that it loads the video completely in one request (requests the full range) but still can't seek. |
This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions. |
openzim/ted@e4f9cc4 fixes it. We can thus tweak our template to detect no-webm support and apply the same CSS tweaks. |
@satyamtg Would you be able please to fix that one like you fixed TED. We would then have to make a new release of the youtube2zim. |
On all apple readers (macOS and iOS Kiwix) but also Safari for both OS, the video progress bar displays properly and moves along with playing but it's impossible to seek to a different position.
Clicking anywhere on the bar has same effect as clicking on current position: a quick pause/play.
We should test if this affects mp4 video as well (natively supported) and if not, it's most probably an issue with ogvjs.
The text was updated successfully, but these errors were encountered: