Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to seek on apple browsers #91

Closed
rgaudin opened this issue Apr 28, 2020 · 9 comments · Fixed by #119
Closed

Unable to seek on apple browsers #91

rgaudin opened this issue Apr 28, 2020 · 9 comments · Fixed by #119
Assignees
Labels

Comments

@rgaudin
Copy link
Member

rgaudin commented Apr 28, 2020

On all apple readers (macOS and iOS Kiwix) but also Safari for both OS, the video progress bar displays properly and moves along with playing but it's impossible to seek to a different position.

Clicking anywhere on the bar has same effect as clicking on current position: a quick pause/play.

We should test if this affects mp4 video as well (natively supported) and if not, it's most probably an issue with ogvjs.

@rgaudin rgaudin added the bug label Apr 28, 2020
@rgaudin rgaudin self-assigned this Apr 28, 2020
@satyamtg
Copy link
Contributor

satyamtg commented May 8, 2020

@rgaudin I can confirm that this is an issue with ogvjs. We can actually reproduce this on other platforms than Apple by simply changing the techOrder": ["html5", "ogvjs"] to techOrder": ["ogvjs"] in the templates which will force videojs to use ogvjs to play videos. We also see errors in console saying that video is unseekable.

@rgaudin
Copy link
Member Author

rgaudin commented May 8, 2020

OK I'm leaving this open but categorizing it as awaiting-upstream.

@kelson42
Copy link
Contributor

kelson42 commented Jun 2, 2020

@rgaudin @satyamtg I would check again this with http://library.kiwix.org/mali-pour-les-nuls_fr_all_2020-04 because we have now there a kiwix-serve which should support byte-range requests properly.

@rgaudin
Copy link
Member Author

rgaudin commented Jun 4, 2020

No improvement using 3.1.1:

Error: Cannot seek a non-seekable stream
if (this._stream && !this._stream.seekable)
  throw new Error("Cannot seek a non-seekable stream");
--
seekable: {
  get: function get() {
    return this.demuxer.seekable
  }
},

The ogv.js readme: clearly states that this should work with Range header.

Actually, when testing the build folder of the zim file outside kiwix-serve, it seeks as expected.

It's hard to debug what happens with the devtools but it seems that it loads the video completely in one request (requests the full range) but still can't seek.

@stale
Copy link

stale bot commented Aug 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Aug 4, 2020
@rgaudin
Copy link
Member Author

rgaudin commented Sep 11, 2020

openzim/ted@e4f9cc4 fixes it. We can thus tweak our template to detect no-webm support and apply the same CSS tweaks.

@stale stale bot removed the stale label Sep 11, 2020
@kelson42
Copy link
Contributor

@satyamtg @rgaudin Seems quite important to rapidly fix this on this scraper as well and make a new release.

@kelson42
Copy link
Contributor

@satyamtg Would you be able please to fix that one like you fixed TED. We would then have to make a new release of the youtube2zim.

@kelson42 kelson42 assigned satyamtg and unassigned rgaudin Sep 14, 2020
@kelson42 kelson42 added bug and removed upstream labels Sep 14, 2020
@satyamtg
Copy link
Contributor

satyamtg commented Sep 14, 2020

@satyamtg Would you be able please to fix that one like you fixed TED. We would then have to make a new release of the youtube2zim.

If you are talking of this issue, I have already added the fix in #119. Waiting for a review from @rgaudin. I don't have an apple device, so can't really test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants