Reduce configuration to one (or max two) short properties #5
Comments
|
Currently only 2 conf params are mandatory (rest are supplied for overwriting defaults):
The first one being passed using the property launcher which leaves only the second one - I have not tried but I guess we can pass system variables via command line. I will check. UPDATEYes it does. It worked as system properties so it is mainly question of shortening it. I will do that - expect a PR soon. |
This uses a spring profile to make configuration like other Zipkin components. This doesn't prevent property file configuration, rather suggests the same style here as we do elsewhere. This also cleans up tests and simplifies the startup instructions. Ex. ``` bash cd /tmp EVENTHUB_CONNECTION_STRING=foo EVENTHUB_STORAGE_CONNECTION_STRING=bar java -Dloader.path=eventhub -Dspring.profiles.active=eventhub -cp zipkin.jar org.springframework.boot.loader.PropertiesLauncher ``` You'll notice the convention of using the same directory of loader path as the server profile. This is intentional as I think it will make docker or other server setup easier. For example, the java command can be templated. Fixes #5 See #7
|
here's an implementation along with some fixes and other suggestions #9 |
|
actually, it doesn't completely solve this because I still don't have good docs or instructions to derive the mandatory properties.. @aliostad maybe you can help with that after the fact? |
|
Is it not better to read environment variables in the auto configuration so not having to rely on the YAML file? e.g. |
|
Is it not better to read environment variables in the auto configuration
so not having to rely on the YAML file? e.g. System.getenv("EVENTHUB_
CONNECTION_STRING"), etc
This is only to support the server profile, which can be disabled. The
auto-configuration files itself shouldn't read the environment, as things
like profiles address that concern.
|
…model data model changes to add name, id and dependency for sr annotaiton
Right now, there's a long description of creating a properties file which includes all but one property. Each of these are in long form, like
zipkin.collector.eventhub.connection-string. To get a similar experience with other services, we'd ideally have one or two required properties in short form (likeEVENTHUB_CONNECTION_STRING, taking anything we can from host installed defaults (if exist)The following are good examples of where a short env variable is available, which allows people to literally hand type a commandline in as needed!
ES_AWS_DOMAINto use hosted storage.PROJECT_IDThe text was updated successfully, but these errors were encountered: