Consolidates notes on "extra" data #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, notes about state, particularly the "one instance per plugin" rule were not consolidated on the method that can cause problems `addExtra`. This migrates notes together with additional warnings that when we talk about this being used for propagation plugins, we also mean not for ad-hoc usage, as that can lead to excessive overhead. See #1421 Signed-off-by: Adrian Cole <adrian@tetrate.io>
| * @since 4.9 | ||
| */ | ||
| public final List<Object> extra() { |
There was a problem hiding this comment.
type is final, so this is redundant
reta
reviewed
Mar 12, 2024
| @@ -372,6 +374,24 @@ public Builder clearExtra() { | |||
| } | |||
|
|
|||
| /** | |||
| * This is an advanced function used for {@link Propagation} plugins, such as | |||
reta
approved these changes
Mar 12, 2024
|
thanks for the look @reta! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, notes about state, particularly the "one instance per plugin" rule were not consolidated on the method that can cause problems
addExtra. This migrates notes together with additional warnings that when we talk about this being used for propagation plugins, we also mean not for ad-hoc usage, as that can lead to excessive overhead.See #1421