Try/Catch everything in the servlet filter to be safe (and a bit paranoid) #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @kristofa how do you feel about this pull request? |
|
Ok, sorry for the delay @joeslice . Good that you reminded me this one was still open. |
kristofa
added a commit
that referenced
this pull request
Jan 29, 2015
Try/Catch everything in the servlet filter to be safe (and a bit paranoid)
|
Great; thanks for merging this! |
|
Hey @kristofa when are you next planning to release? I'd like to get our services using this change. |
|
@srapp I made the brave release that contains this pull request. See here for release notes. It should become available in Maven Central shortly. |
|
Awesome, thanks @kristofa ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think all the exception-causing spots have been addressed, but as we've seen with #49 and #54, unexpected exceptions cause our restful services to return a 500.
This change will make the 500's just warn and continue, strengthening the guarantee that the tracing library won't negatively impact your application in performance or otherwise.