Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix openzipkin/zipkin-dependencies/issues/192 #194

Merged
merged 2 commits into from
Mar 11, 2021

Conversation

dankolt
Copy link
Contributor

@dankolt dankolt commented Mar 6, 2021

No description provided.

@jorgheymans
Copy link
Contributor

Can you explain a bit what it is you're trying to fix here ?

@dankolt
Copy link
Contributor Author

dankolt commented Mar 7, 2021

Can you explain a bit what it is you're trying to fix here ?

Bug describes in #192.
When we start dependencies container crond interrupts with message:
crond[1]: root: Permission denied
It happens because crond starts by zipkin-dependencies user but scripts copied in Dockerfile with root owner.
So I changed this behaviour and dependencies job start working now.

@jorgheymans
Copy link
Contributor

Thanks for the clarification! @shakuzen are you ok with this fix ?

@shakuzen
Copy link
Member

shakuzen commented Mar 9, 2021

Error: Failed to execute goal com.mycila:license-maven-plugin:4.0.rc2:check (default) on project zipkin-dependencies-parent: Some files do not have the expected license header

I am guessing the license header end year of the Dockerfile needs to be extended to 2021.

Otherwise, LGTM.

- Fix missing headers error
@dankolt
Copy link
Contributor Author

dankolt commented Mar 9, 2021

Error: Failed to execute goal com.mycila:license-maven-plugin:4.0.rc2:check (default) on project zipkin-dependencies-parent: Some files do not have the expected license header

I am guessing the license header end year of the Dockerfile needs to be extended to 2021.

Otherwise, LGTM.

Exactly! Thanks!

@jorgheymans jorgheymans merged commit 50f4c03 into openzipkin:master Mar 11, 2021
@ipavlushin
Copy link

Hi @jorgheymans @shakuzen !
Could you also build and push Docker image with these changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants