Rewrite axios integration tests to use v2 syntax and also execute in browser #372
Conversation
| const ctxImpl = new ExplicitContext(); | ||
| const recorder = {record}; | ||
| const recorder = new BatchRecorder({logger: {logSpan: (span) => { |
There was a problem hiding this comment.
here is how to get javascript objects that look exactly like v2 json
| verifyGetSpan({ | ||
| 'http.path': badPath, | ||
| 'http.status_code': '500', | ||
| 'error': '500' |
There was a problem hiding this comment.
this is a good example as it shows all tags succinctly are in the same span document
| @@ -6,14 +6,13 @@ | |||
| "scripts": { | |||
| "build": "babel src -d lib", | |||
| "test": "mocha --exit --require ../../test/helper.js", | |||
| "test-browser": "karma start --single-run --browsers ChromeHeadless ../../karma.conf.js", | |||
There was a problem hiding this comment.
cc @ewhauser now this module can pass tests in the browser, even integration tests
| @@ -1,3 +1,6 @@ | |||
| const path = require('path'); | |||
| const testMiddleware = require('./test/middleware'); | |||
There was a problem hiding this comment.
this sneakily mounts stub endpoints on the server that hosts the test classes used in browser testing. that way integration tests work both in and out of browser environment
| @@ -16,6 +16,7 @@ | |||
| "test:ts": "tsr packages/zipkin/test-types/*.test.ts --noAnnotate --libDeclarations && mocha --opts test/mocha-types.opts", | |||
| "test": "npm run test:es && npm run test:ts", | |||
| "lerna-test": "lerna run test", | |||
| "lerna-test-browser": "lerna run test-browser", | |||
There was a problem hiding this comment.
Ex npm run lerna-test-browser -- --scope zipkin-instrumentation-axiosjs
| const path = '/weather/wuhan'; | ||
| const url = () => `${baseUrl}${path}?index=10&count=300`; // defers access to baseUrl | ||
|
|
||
| function verifyGetSpan(tags) { |
There was a problem hiding this comment.
example full data comparison.. much better than looking at annotations, right?
|
ps I know build is broke btw I mainly wanted to open for feedback while I polish things.. |
codefromthecrypt
changed the title
|
ok the build is cleaner now, and I backfilled a missing test and some missing defensive code. |
… browser This extracts middleware such that axios tests can execute normally and also in browser with Karma. It also swaps assertion style to v2 for clarity.
codefromthecrypt
force-pushed
the
refactor-axios-tests-2
branch
from
3bda420
to
b37754c
Compare
|
fixed merge conflicts arising from last nights release |
|
some old firefox will look into it |
|
Merging to carry on and do the other http clients while in the zone. I'll take any questions/feedback post merge. |
This extracts middleware such that axios tests can execute normally and also
in browser with Karma. It also swaps assertion style to v2 for clarity.