Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collector: Default to sample all spans in dev config #195

Closed
wants to merge 3 commits into from
Closed

collector: Default to sample all spans in dev config #195

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c05ab2b
Default to use sample everything in dev config
Oct 31, 2012
aaea2c9
Fix doc
Oct 31, 2012
f3d0c66
Moar docs
Nov 2, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions zipkin-collector-service/config/collector-dev.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/

import com.twitter.zipkin.collector.sampler.EverythingGlobalSampler
import com.twitter.zipkin.config._
import com.twitter.zipkin.config.sampler.NullAdaptiveSamplerConfig
import com.twitter.zipkin.config.zookeeper.ZooKeeperConfig
Expand Down Expand Up @@ -60,6 +62,9 @@ new ScribeZipkinCollectorConfig {

override def adaptiveSamplerConfig = new NullAdaptiveSamplerConfig {}

/* Default to sample everything */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps describe what the collector sampling stage does in a bit more detail here? Mention that if the collector gets too much traffic the next step would be to use the adaptive sampler.

override def globalSampler = EverythingGlobalSampler

def zkConfig = new ZooKeeperConfig {
servers = List("localhost:2181")
}
Expand Down