Variables refactor #108
Merged
Variables refactor #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plorenz
force-pushed
the
variables-refactor
branch
from
f5c1c43
to
8952140
Compare
plorenz
force-pushed
the
variables-refactor
branch
from
7ad9e97
to
606cbdf
Compare
michaelquigley
approved these changes
Jun 4, 2021
kernel/lib/fabutil/errors.go
Outdated
| @@ -0,0 +1,23 @@ | |||
| package fabutil | |||
There was a problem hiding this comment.
can we just call fabutil util?
There was a problem hiding this comment.
renamed. I try to avoid util/utils sometimes because package name collision is a bigger issue in golang and it often feels like every module has a util.
kernel/model/variables.md
Outdated
Comment on lines
48
to
57
| 1. Scope local cache, for already resolved variables | ||
| 1. Parent Scope with path | ||
| 1. Parent Scope without path | ||
| 1. Binding with path | ||
| 1. Binding without path | ||
| 1. Command line override with path | ||
| 1. Command line override without path | ||
| 1. Environment variable with path | ||
| 1. Environment variable without path | ||
| 1. A constant value (used for providing defaults) |
There was a problem hiding this comment.
didn't we already resolve this discussion? also, this list looks like it's missing the label resolver stuff.
There was a problem hiding this comment.
Doc was outdated, removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.