Skip to content
This repository has been archived by the owner on Nov 14, 2023. It is now read-only.

${ZITI_SOURCE} 2 #16

Closed
michaelquigley opened this issue Dec 6, 2019 · 2 comments
Closed

${ZITI_SOURCE} 2 #16

michaelquigley opened this issue Dec 6, 2019 · 2 comments
Milestone

Comments

@michaelquigley
Copy link
Collaborator

michaelquigley commented Dec 6, 2019

I agree. It's the way it is b/c if ZITI_SOURCE isn't specified, it evaluates to blank and we end up with a relative path ziti-fabric/etc if there's no slash, or an absolute path /ziti-fabric/etc if there is.

If having the absolute path as a fallback is OK, I can switch it.
I considered adding logic to check for empty ZITI_SOURCE but there's nothing special about it. Other people might use different values in their config files, so it seemed a little strange to add something to the code for it.

Thoughts?

Originally posted by @plorenz in #15

@michaelquigley
Copy link
Collaborator Author

We're probably going to want to revisit this with an overall cleaner approach, at some point. I don't actually run my builds out of ~/Repos/nf (the parent directory for ziti-fabric), so this is kind of broken for my workflow anyway.

@michaelquigley michaelquigley added this to the Phase 14: Fabric 1.0 milestone Feb 5, 2020
@michaelquigley michaelquigley changed the title ${ZITI_SOURCE} v2 ${ZITI_SOURCE} 2 Feb 14, 2020
@plorenz
Copy link
Member

plorenz commented Dec 21, 2022

Replacing this with openziti/ziti#1426 , which has a concrete proposal for making nicer relative paths in config files.

@plorenz plorenz closed this as completed Dec 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants