Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support making relative paths in config, relative to the config file instead of the current dir of spawning process #1426

Open
plorenz opened this issue Dec 8, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request fabric Issue is related to fabric level functionality

Comments

@plorenz
Copy link
Member

plorenz commented Dec 8, 2022

No description provided.

@plorenz plorenz added the enhancement New feature or request label Dec 8, 2022
@dovholuknf
Copy link
Member

will it still support full paths or does this force the paths to be relative?

@plorenz
Copy link
Member Author

plorenz commented Dec 8, 2022

will it still support full paths or does this force the paths to be relative?

This is only about how to evaluate relative paths. Full/absolute paths would always be evaluated as such.

We could also offer options either from the command line and/or in the config file to tell it how to interpret relative paths.

Some thing like:

pathsRelativeTo: config|binary|env

where binary would be the ziti binary being run, config is the config file directory and env is whatever the default is.

@plorenz
Copy link
Member Author

plorenz commented Dec 9, 2022

A better approach would be to inject the config dir and the executable dir into the environment. Then we could use the env support.

So define zitiConfigDir and zitiBinDir. Then you could do things like:

identity:
  cert: ${zitiConfigDir}/certs/server.cert

@plorenz plorenz transferred this issue from openziti/fabric Oct 11, 2023
@plorenz plorenz added the fabric Issue is related to fabric level functionality label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fabric Issue is related to fabric level functionality
Projects
None yet
Development

No branches or pull requests

2 participants