Condition linux TCP keepalive sockopts #202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's specific for Linux, so condition it on __linux__
ekoby
reviewed
Feb 22, 2024
| @@ -169,8 +169,10 @@ int tlsuv_stream_keepalive(tlsuv_stream_t *clt, int keepalive, unsigned int dela | |||
| #if defined(TCP_KEEPALIVE) | |||
| setsockopt(s, IPPROTO_TCP, TCP_KEEPALIVE, &delay, sizeof(delay)); | |||
| #endif | |||
| #if __linux__ | |||
There was a problem hiding this comment.
it would be better to condition on the macro definitions -- TCP_KEEPINTVL and TCP_KEEPCNT
those options are NOT linux exclusive:
https://learn.microsoft.com/en-us/windows/win32/winsock/ipproto-tcp-socket-options
see above
|
dup #212 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's specific for Linux, so condition it on linux.
This change was introduced rather recently and I presume no one attempted to compile it on anything that's not Linux. It would be great with cross-platform CI builds to catch things like this...