Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prometheus-ai-project for team promethues-ai #1375

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Add prometheus-ai-project for team promethues-ai #1375

merged 1 commit into from
Nov 29, 2021

Conversation

benlugasi
Copy link
Contributor

Hey,
I've added a project for our group (that was added earlier) following this guide.

@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 28, 2021
@sesheta sesheta added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 28, 2021
@sesheta
Copy link
Member

sesheta commented Nov 28, 2021

Hi @benlugasi. Thanks for your PR.

I'm waiting for a operate-first member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@benlugasi
Copy link
Contributor Author

/assign @durandom

@benlugasi
Copy link
Contributor Author

/assign @4n4nd

@benlugasi benlugasi mentioned this pull request Nov 28, 2021
Closed
@4n4nd
Copy link
Contributor

4n4nd commented Nov 29, 2021

/ok-to-test

@sesheta sesheta added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 29, 2021
@benlugasi benlugasi closed this Nov 29, 2021
@benlugasi benlugasi reopened this Nov 29, 2021
harshad16
harshad16 requested changes Nov 29, 2021
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
some changes needed:

cluster-scope/base/core/namespaces/prometheus-ai-project/kustomization.yaml Show resolved Hide resolved
@4n4nd
Copy link
Contributor

4n4nd commented Nov 29, 2021

@benlugasi I will work on updating the docs for quotas
This PR looks good 👍
Can you just squash the commits to one?

@benlugasi
Copy link
Contributor Author

Changes applied @harshad16

harshad16
harshad16 reviewed Nov 29, 2021
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 💯

@benlugasi
Copy link
Contributor Author

@benlugasi I will work on updating the docs for quotas This PR looks good 👍 Can you just squash the commits to one?

Sure, Thanks

@benlugasi
Copy link
Contributor Author

squashed

harshad16
harshad16 reviewed Nov 29, 2021
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2021
4n4nd
4n4nd approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@4n4nd 4n4nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sesheta
Copy link
Member

sesheta commented Nov 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 4n4nd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2021
@sesheta sesheta merged commit 6e16d9e into operate-first:master Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshad16 harshad16 harshad16 requested changes

@4n4nd 4n4nd 4n4nd approved these changes

@hemajv hemajv Awaiting requested review from hemajv

Assignees

@durandom durandom

@harshad16 harshad16

@4n4nd 4n4nd

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@benlugasi @sesheta @4n4nd @harshad16 @durandom