Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding github secret to kustomize #158

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

hemajv
Copy link
Member

@hemajv hemajv commented Jan 25, 2021

Including the GitHub alertmanager receiver secret in kustomize, as secret management is now in place

Related to #77

@hemajv hemajv requested a review from 4n4nd January 25, 2021 21:37
@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 25, 2021
@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2021
Copy link
Contributor

@4n4nd 4n4nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@sesheta
Copy link
Member

sesheta commented Jan 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 4n4nd, HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta merged commit 2ebb0ab into operate-first:master Jan 26, 2021
eranra pushed a commit to eranra/apps that referenced this pull request Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants