Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust grafana dashboards and documentation #218

Merged
merged 2 commits into from
Feb 8, 2021

Conversation

pacospace
Copy link
Member

@pacospace pacospace commented Feb 8, 2021

Remove spec.name from dashboards and docs, as it is not used in grafana operator GrafanaDashboard CRDs.

Related-To: grafana/grafana-operator#344

Francesco Murdaca added 2 commits February 5, 2021 22:53
Signed-off-by: Francesco Murdaca <fmurdaca@redhat.com>
Signed-off-by: Francesco Murdaca <fmurdaca@redhat.com>
@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 8, 2021
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, sir! 🥇 Thank you for taking this back to the upstream! 👍

/approve

@sesheta
Copy link
Member

sesheta commented Feb 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2021
@sesheta sesheta merged commit 308e628 into operate-first:master Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants