Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ai4cloudops group #2725

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Update ai4cloudops group #2725

merged 1 commit into from
Feb 1, 2023

Conversation

eth1030
Copy link
Contributor

@eth1030 eth1030 commented Feb 1, 2023

No description provided.

@sesheta sesheta added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 1, 2023
@sesheta
Copy link
Member

sesheta commented Feb 1, 2023

Hi @eth1030. Thanks for your PR.

I'm waiting for a operate-first member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tumido tumido changed the title Update group.yaml Update ai4cloudops group Feb 1, 2023
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @eth1030! Welcome! 🙂

@mtoslalibu or @syedmohdqasim please confirm this membership request.

@eth1030 please know once merged it may happen that this doesn't grant you required access. We'll try it and merge this PR first, but I'm telling you just in case. 🙂

In case it doesn't work, you may then also need to add yourself to the github org via a PR against this list (please include your github handle in alphabetical order):

https://github.com/operate-first/common/blob/main/github-config.yaml#L18

@tumido
Copy link
Member

tumido commented Feb 1, 2023

/ok-to-test
/hold

@sesheta sesheta added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 1, 2023
@tumido
Copy link
Member

tumido commented Feb 1, 2023

@syedmohdqasim confirmed on Slack
/unhold

@sesheta sesheta removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2023
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2023
@sesheta
Copy link
Member

sesheta commented Feb 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2023
@mtoslalibu
Copy link

/lgtm

@sesheta sesheta merged commit 986f9a0 into operate-first:master Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants