Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add current dump of Google Cloud DNS configuration #2736

Merged
merged 2 commits into from
Feb 15, 2023
Merged

add current dump of Google Cloud DNS configuration #2736

merged 2 commits into from
Feb 15, 2023

Conversation

goern
Copy link
Member

@goern goern commented Feb 15, 2023

Signed-off-by: Christoph Görn goern@redhat.com

@goern
add current dump of Google Cloud DNS configuration
c370551 
Signed-off-by: Christoph Görn <goern@redhat.com>
@sesheta sesheta added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 15, 2023
@sesheta
Copy link
Member

sesheta commented Feb 15, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@goern goern added the kind/documentation Categorizes issue or PR as related to documentation. label Feb 15, 2023
@goern goern marked this pull request as ready for review February 15, 2023 15:43
@sesheta sesheta removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 15, 2023
@goern
Copy link
Member Author

goern commented Feb 15, 2023

This PR feeds into operate-first/support#1230

tumido
tumido requested changes Feb 15, 2023
View reviewed changes
dns/OWNERS Show resolved Hide resolved
@goern
add a DNS specific OWNERS file
7d58869 
Signed-off-by: Christoph Görn <goern@redhat.com>
tumido
tumido approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2023
@sesheta
Copy link
Member

sesheta commented Feb 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2023
@sesheta sesheta merged commit dd62986 into operate-first:master Feb 15, 2023
@goern goern deleted the support/issues/1230 branch February 16, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tumido tumido tumido approved these changes

@durandom durandom Awaiting requested review from durandom

Assignees

@tumido tumido

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goern @sesheta @tumido