Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add goern to some admin groups, so that he can help out #2755

Merged
merged 3 commits into from
Mar 9, 2023
Merged

add goern to some admin groups, so that he can help out #2755

merged 3 commits into from
Mar 9, 2023

Conversation

goern
Copy link
Member

@goern goern commented Mar 7, 2023

  • update the pre-commit container image
  • update the pre-commit hook versions
  • add goern to a few admin groups

@goern
update the pre-commit container image
a962efe 
Signed-off-by: Christoph Görn <goern@redhat.com>
@goern
update the pre-commit hook versions
f6c99e5 
Signed-off-by: Christoph Görn <goern@redhat.com>
@goern
add goern to a few admin groups
4977194 
Signed-off-by: Christoph Görn <goern@redhat.com>
@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 7, 2023
tumido
tumido approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2023
@sesheta
Copy link
Member

sesheta commented Mar 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2023
@goern
Copy link
Member Author

goern commented Mar 9, 2023

@tumido could you qualify the kubeval check? is that ok? can we merge?

@tumido
Copy link
Member

tumido commented Mar 9, 2023

/retest

@tumido
Copy link
Member

tumido commented Mar 9, 2023

@goern it just timed out. Retest should help.

@goern
Copy link
Member Author

goern commented Mar 9, 2023

/test kubeval-validation

1 similar comment
@tumido
Copy link
Member

tumido commented Mar 9, 2023

/test kubeval-validation

@tumido
Copy link
Member

tumido commented Mar 9, 2023

sigh...

/override kubeval-validation

@sesheta
Copy link
Member

sesheta commented Mar 9, 2023

@tumido: Overrode contexts on behalf of tumido: aicoe-ci/prow/kubeval-validation

In response to this:

sigh...

/override kubeval-validation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta merged commit 84412f0 into operate-first:master Mar 9, 2023
@goern goern deleted the make-goern-a-sre branch March 9, 2023 15:31
@goern goern mentioned this pull request Mar 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tumido tumido tumido approved these changes

@durandom durandom Awaiting requested review from durandom

@codificat codificat Awaiting requested review from codificat

@harshad16 harshad16 Awaiting requested review from harshad16

@Gregory-Pereira Gregory-Pereira Awaiting requested review from Gregory-Pereira

@schwesig schwesig Awaiting requested review from schwesig

Assignees

@tumido tumido

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goern @sesheta @tumido