Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Increase kubeval job memory request to 1GB #2761

Merged
merged 1 commit into from
Mar 13, 2023
Merged

fix: Increase kubeval job memory request to 1GB #2761

merged 1 commit into from
Mar 13, 2023

Conversation

mimotej
Copy link
Member

@mimotej mimotej commented Mar 13, 2023

It seems that the #2759 fails because of not enough memory for kubeval validation. This PR increases this limit to 1GB

@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 13, 2023
@mimotej
Copy link
Member Author

mimotej commented Mar 13, 2023

/cc @tumido

@sesheta sesheta requested a review from tumido March 13, 2023 10:34
@mimotej mimotej changed the title fix: Increase kubeval job emory request to 1GB fix: Increase kubeval job memory request to 1GB Mar 13, 2023
fix: Increase kubeval job memory request to 1GB
95ed3a6 
Signed-off-by: Michal Drla <mdrla@redhat.com>
@mimotej mimotej force-pushed the update-memory-limit-kubeval branch from 185ab17 to 95ed3a6 Compare March 13, 2023 10:40
tumido
tumido approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2023
@sesheta
Copy link
Member

sesheta commented Mar 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2023
@sesheta sesheta merged commit 4ae1911 into operate-first:master Mar 13, 2023
@mimotej mimotej mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tumido tumido tumido approved these changes

Assignees

@tumido tumido

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mimotej @sesheta @tumido