feat: Add MachineWithoutValidNode alert #2765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sesheta
added
the
size/S
mimotej
changed the title
|
/cc @tumido |
Signed-off-by: Michal Drla <mdrla@redhat.com>
mimotej
force-pushed
the
add-MachineWithoutValidNode-alert
branch
from
2ce428b
to
a461b89
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tumido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sesheta
added
approved
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a MachineWithoutValidNode alert.
The metrics it uses do not include
managed_cluster_idlabel by default but they have
clusterIDinstead. In this caseclusterIDis the ID of the cluster the alert originated in (therefore we can definemanaged_cluster_idlabel ourselves). For now I used following guide If you have ideas for better guide feel free to point them out.