Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removal of healthy apps that migrated #2777

Closed
wants to merge 1 commit into from

Conversation

cooktheryan
Copy link
Contributor

The applications removed here have been migrated and defined in the new OSC repository. To help from dual syncing we should remove.

Signed-off-by: Ryan Cook <rcook@redhat.com>
@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 3, 2023
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2023
@sesheta
Copy link
Member

sesheta commented Apr 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2023
@@ -1,20 +1,10 @@
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- acme-operator.yaml
- cloudbeaver.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to remove the orhphaned Application resources as well?

@goern
Copy link
Member

goern commented May 29, 2023

@cooktheryan this one has a few conflicts, would you like to resolve them or close?

@cooktheryan
Copy link
Contributor Author

Should be able to close

@cooktheryan cooktheryan deleted the osc_turndown branch May 30, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants