Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing osc references from infra ACM #2779

Conversation

Gregory-Pereira
Copy link
Member

Addresses: os-climate/os_c_data_commons#288
/cc @cooktheryan
/cc @redmikhail
Do not merge until creds are backed up for kubeadmin to 3 OSC clusters to new vault instance (as mentioned here: os-climate/os_c_data_commons#288 (comment))
/hold

Signed-off-by: greg pereira <grpereir@redhat.com>
@sesheta sesheta added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 10, 2023
@redmikhail
Copy link
Contributor

/approve

@sesheta
Copy link
Member

sesheta commented Apr 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: redmikhail

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2023
@redmikhail
Copy link
Contributor

/lgtm

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2023
@Gregory-Pereira Gregory-Pereira merged commit 7bcb57b into operate-first:master Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants