Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tekton): Add new pipeline resource permissions for tekton plugin #2791

Merged
merged 1 commit into from
May 5, 2023

Conversation

debsmita1
Copy link
Contributor

pipelinerun and taskrun resource permissions are required for fetching these resources in the Tekton plugin

/cc @tumido

@sesheta sesheta requested a review from tumido May 5, 2023 10:08
@sesheta sesheta added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 5, 2023
@sesheta
Copy link
Member

sesheta commented May 5, 2023

Hi @debsmita1. Thanks for your PR.

I'm waiting for a operate-first member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label May 5, 2023
@sesheta
Copy link
Member

sesheta commented May 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2023
@tumido
Copy link
Member

tumido commented May 5, 2023

/retest

@tumido
Copy link
Member

tumido commented May 5, 2023

/override kubeval-validation
/override kustomize-build
/override pre-commit

verified manually

@tumido
Copy link
Member

tumido commented May 5, 2023

/ok-to-test

@sesheta sesheta added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 5, 2023
@sesheta
Copy link
Member

sesheta commented May 5, 2023

@tumido: Overrode contexts on behalf of tumido: aicoe-ci/prow/kubeval-validation, aicoe-ci/prow/kustomize-build, aicoe-ci/prow/pre-commit

In response to this:

/override kubeval-validation
/override kustomize-build
/override pre-commit

verified manually

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tumido tumido merged commit c8dbddd into operate-first:master May 5, 2023
@sesheta
Copy link
Member

sesheta commented May 5, 2023

@debsmita1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
aicoe-ci/prow/pre-commit f5ce029 link true /test pre-commit
aicoe-ci/prow/kubeval-validation f5ce029 link true /test kubeval-validation
aicoe-ci/prow/kustomize-build f5ce029 link true /test kustomize-build

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants