Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧽 remove pulp from deployment, but keep the assets in the repo #2796

Merged
merged 2 commits into from
May 16, 2023

Conversation

goern
Copy link
Member

@goern goern commented May 16, 2023

Signed-off-by: Christoph Görn goern@b4mad.net

Signed-off-by: Christoph Görn <goern@b4mad.net>
@op1st-prow op1st-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 16, 2023
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are few files missing to be removed. 🙂 Otherwise LGTM.

service-catalog/apis.yaml Show resolved Hide resolved
service-catalog/components.yaml Show resolved Hide resolved
service-catalog/groups.yaml Show resolved Hide resolved
service-catalog/systems.yaml Show resolved Hide resolved
service-catalog/users.yaml Show resolved Hide resolved
Signed-off-by: Christoph Görn <goern@b4mad.net>
@op1st-prow op1st-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 16, 2023
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@op1st-prow op1st-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2023
@op1st-prow
Copy link

op1st-prow bot commented May 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@op1st-prow op1st-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2023
@goern
Copy link
Member Author

goern commented May 16, 2023

/override op1st/prow/pre-commit

@op1st-prow
Copy link

op1st-prow bot commented May 16, 2023

@goern: Overrode contexts on behalf of goern: op1st/prow/pre-commit

In response to this:

/override op1st/prow/pre-commit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@op1st-prow op1st-prow bot merged commit 0d1877d into operate-first:master May 16, 2023
@goern goern deleted the remove-pulp branch May 16, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants