Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add adr for on call process. #108

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Add adr for on call process. #108

merged 1 commit into from
Aug 2, 2022

Conversation

HumairAK
Copy link
Member

@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 26, 2022
@HumairAK HumairAK mentioned this pull request Jul 26, 2022
Closed
5 tasks
schwesig
schwesig reviewed Jul 26, 2022
View reviewed changes
Copy link
Contributor

@schwesig schwesig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have one or more links to the go-to run books, or where/ how to add/ update the documentation?

@schwesig
Copy link
Contributor

/kind documentation
/kind governance

/cc @durandom
/cc @goern

@sesheta sesheta requested review from durandom and goern July 26, 2022 17:24
@sesheta sesheta added kind/documentation Categorizes issue or PR as related to documentation. kind/governance Indicates an issue/PR is related to governance. labels Jul 26, 2022
@schwesig
Copy link
Contributor

@VannTen
@mimotej
@SamoKopecky
@tumido
@Gregory-Pereira

@HumairAK
Copy link
Member Author

HumairAK commented Aug 1, 2022 •
edited
Loading

Do we have one or more links to the go-to run books, or where/ how to add/ update the documentation?

@schwesig https://www.operate-first.cloud/apps/CONTRIBUTING.html

@schwesig
Copy link
Contributor

schwesig commented Aug 1, 2022

Do we have one or more links to the go-to run books, or where/ how to add/ update the documentation?

@schwesig operate-first.cloud/apps/CONTRIBUTING.html

Should we add this link to the document? Or is this common knowledge/ already exists in readme etc and I missed that?

schwesig
schwesig reviewed Aug 1, 2022
View reviewed changes
Copy link
Contributor

@schwesig schwesig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
the idea about adding the link to the docs https://www.operate-first.cloud/apps/CONTRIBUTING.html is not a blocker for me.

adr/0021-sre-cloud-support.md Outdated Show resolved Hide resolved
@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2022
@schwesig schwesig self-requested a review August 1, 2022 15:48
schwesig
schwesig reviewed Aug 1, 2022
View reviewed changes
Copy link
Contributor

@schwesig schwesig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
adding https://www.operate-first.cloud/apps/CONTRIBUTING.html is not a blocker

@sesheta sesheta removed the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2022
@durandom
Copy link
Member

durandom commented Aug 2, 2022

/lgtm
/approve

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2022
@durandom
Copy link
Member

durandom commented Aug 2, 2022 •
edited
Loading

good job @HumairAK and @schwesig

@sesheta
Copy link
Member

sesheta commented Aug 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: durandom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2022
@sesheta sesheta merged commit 634b706 into operate-first:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schwesig schwesig schwesig left review comments

@durandom durandom Awaiting requested review from durandom

@goern goern Awaiting requested review from goern

Assignees

@durandom durandom

@schwesig schwesig

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. kind/governance Indicates an issue/PR is related to governance. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a process for SRE On-Call and support handling for Operate First Cloud
4 participants
@HumairAK @schwesig @durandom @sesheta