Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add b4mad #138

Merged
merged 1 commit into from
Mar 25, 2021
Merged

add b4mad #138

merged 1 commit into from
Mar 25, 2021

Conversation

durandom
Copy link
Member

cc @goern

/hold

@sesheta sesheta added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2021
@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 25, 2021
@durandom durandom mentioned this pull request Mar 25, 2021
Closed
@goern
Copy link
Member

goern commented Mar 25, 2021

/lgtm

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2021
@durandom
Copy link
Member Author

/unhold

@tumido pls review

@sesheta sesheta removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2021
@durandom durandom mentioned this pull request Mar 25, 2021
Merged
@durandom
Copy link
Member Author

corresponding PR operate-first/argocd-apps#121

tumido
tumido approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sesheta
Copy link
Member

sesheta commented Mar 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2021
@sesheta sesheta merged commit 546d513 into operate-first:master Mar 25, 2021
@durandom durandom deleted the add_b4mad branch March 25, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tumido tumido tumido approved these changes

@HumairAK HumairAK Awaiting requested review from HumairAK

@ipolonsk ipolonsk Awaiting requested review from ipolonsk

Assignees

@goern goern

@tumido tumido

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@durandom @goern @sesheta @tumido