Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to md to conform with decision on markdown #5

Merged
merged 3 commits into from
Mar 24, 2022
Merged

Change to md to conform with decision on markdown #5

merged 3 commits into from
Mar 24, 2022

Conversation

david-martin
Copy link
Contributor

No description provided.

@david-martin david-martin requested a review from lisa March 22, 2022 16:29
@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 22, 2022
@jeremyeder
Copy link
Contributor

/lgtm

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2022
lisa
lisa approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@lisa lisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some linting issues again, but I'm largely over it in this iteration.

/lgtm
/approve

@sesheta sesheta removed the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2022
@lisa
Copy link
Contributor

lisa commented Mar 23, 2022

/lgtm
/approve

:shipit:

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2022
@sesheta
Copy link
Member

sesheta commented Mar 23, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lisa

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@david-martin david-martin merged commit 59cac21 into operate-first:main Mar 24, 2022
@david-martin david-martin deleted the adoc_to_md branch March 24, 2022 10:08
@hemajv hemajv mentioned this pull request Sep 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lisa lisa lisa approved these changes

Assignees

@lisa lisa

@jeremyeder jeremyeder

Labels
lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@david-martin @jeremyeder @lisa @sesheta