Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use k8s version instead of replace in go.mod #17

Conversation

LouisPlisso
Copy link
Contributor

Now all k8s packages support "native" go module versions (kubernetes 1.16.7 maps to v0.16.7)

This allows for easy upgrades for patch versions and allows other packages to import this api easily

Note that the pinned version was 1.16.2: unfortunately this version did not provide native go module versions, so I bumped it to the latest in 1.16 which is 1.16.7

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 28, 2020
@LouisPlisso
Copy link
Contributor Author

Note that I tested this change by building this repo (go build ./...) and also building operator-registry on top of this change (go build ./...)

@kevinrizza
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2020
@LouisPlisso
Copy link
Contributor Author

@kevinrizza will you please merge and then create a release 0.1.1 so that I can base the other PRs on this tag (I'm currently testing on local forks, but it won't build if this is not publicly available)
Thanks!

@kevinrizza
Copy link
Member

@LouisPlisso Sorry, didn't have a chance to test this before something else merged and now there's a conflict. Can you rebase and update the PR so I can test it before I merge?

Hopefully we can get some CI running against this repo sooner rather than later so we can be a little more automatic. Sorry about the trouble!

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2020
@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 4, 2020
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 4, 2020
@LouisPlisso
Copy link
Contributor Author

@kevinrizza now with the vendor directory included it's a huge PR
I've tested with go build ./... and go test ./...
and built operator-registry on top of this

don't know how to test more

@LouisPlisso
Copy link
Contributor Author

@kevinrizza if you have time, could you please checkout this PR and run a go mod vendor to ensure the vendor directory is stable
it's the 1st time I work with a checked-in vendor, and with a 14k lines PR, it wouldn't hurt to double check 🙏

thanks!

@ecordell
Copy link
Member

ecordell commented Mar 6, 2020

$ git checkout -b LouisPlisso-pin_with_native_k8s_version_no_replace master
$ git pull https://github.com/LouisPlisso/api.git pin_with_native_k8s_version_no_replace
$ go mod vendor
$ go mod tidy
$ git status
On branch LouisPlisso-pin_with_native_k8s_version_no_replace
nothing to commit, working tree clean
$  go build -mod=vendor -o=v ./cmd/operator-verify/

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2020
@ecordell ecordell merged commit d2a2fa2 into operator-framework:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants