-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use k8s version instead of replace in go.mod #17
Use k8s version instead of replace in go.mod #17
Conversation
Note that I tested this change by building this repo ( |
/lgtm |
@kevinrizza will you please merge and then create a release 0.1.1 so that I can base the other PRs on this tag (I'm currently testing on local forks, but it won't build if this is not publicly available) |
@LouisPlisso Sorry, didn't have a chance to test this before something else merged and now there's a conflict. Can you rebase and update the PR so I can test it before I merge? Hopefully we can get some CI running against this repo sooner rather than later so we can be a little more automatic. Sorry about the trouble! |
@kevinrizza now with the vendor directory included it's a huge PR don't know how to test more |
@kevinrizza if you have time, could you please checkout this PR and run a thanks! |
/lgtm |
Now all k8s packages support "native" go module versions (kubernetes 1.16.7 maps to v0.16.7)
This allows for easy upgrades for patch versions and allows other packages to import this api easily
Note that the pinned version was 1.16.2: unfortunately this version did not provide native go module versions, so I bumped it to the latest in 1.16 which is 1.16.7