Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use ssa for status update by default from UpdateControl #2278

Merged
merged 9 commits into from
Mar 18, 2024
Merged

feat: use ssa for status update by default from UpdateControl #2278

merged 9 commits into from
Mar 18, 2024

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Mar 11, 2024

No description provided.

@csviri csviri requested a review from metacosm March 11, 2024 10:29
@openshift-ci openshift-ci bot requested a review from adam-sandor March 11, 2024 10:29
@csviri csviri linked an issue Mar 11, 2024 that may be closed by this pull request
Use Sever Side Apply to Update Status and Manage Finalizers #1931
Closed
metacosm
metacosm reviewed Mar 11, 2024
View reviewed changes
...ramework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationService.java
*
* @return true by default
*/
default boolean useSSAForResourceStatusPatch() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why people who not want to use SSA for status updating?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add an additional test for upgradint from non-SSA to SSA, just added for safety reasons: since there were issues with SSA in the past, also even the non-built in kubernetes controller are not using SSA. So it does not harm to add a feature flag.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it adds complexity for not much. I'd rather we only add the flag if we determine it's needed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the migration from non-SSA to SSA - is not trivial. At least I hit some strange issues today, but will add test. Especially actual users would be safer to have this flag.

@csviri csviri marked this pull request as draft March 11, 2024 19:19
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2024
@csviri csviri force-pushed the ssa-for-status branch 3 times, most recently from 968ab1e to 598dea8 Compare March 15, 2024 14:44
@csviri csviri marked this pull request as ready for review March 18, 2024 09:33
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2024
@csviri csviri requested a review from metacosm March 18, 2024 09:33
csviri and others added 9 commits March 18, 2024 14:03
@csviri
feat: use SSA for resource status patching
1142a88 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
docs
9eccbf4 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
managed fields fix
3f358c4 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@metacosm @csviri
refactor: simplify
1b3626f 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@csviri
format
871f5b7 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
fix IT
b4ce0cd 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
fix on short name
0f02f86 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
Integration test skeleton for SSA handling
6c99a78 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
Integration test
31fbd2c 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri csviri merged commit 5842721 into next Mar 18, 2024
20 checks passed
@csviri csviri deleted the ssa-for-status branch March 18, 2024 13:32
@metacosm metacosm mentioned this pull request Mar 21, 2024
Closed
csviri added a commit that referenced this pull request Apr 10, 2024
@csviri
feat: use ssa for status update by default from UpdateControl (#2278)
bcfebda 

Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm pushed a commit that referenced this pull request Apr 10, 2024
@csviri @metacosm
feat: use ssa for status update by default from UpdateControl (#2278)
6640c1e 

Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm pushed a commit that referenced this pull request Apr 11, 2024
@csviri @metacosm
feat: use ssa for status update by default from UpdateControl (#2278)
2c66093 

Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request May 17, 2024
@csviri
feat: use ssa for status update by default from UpdateControl (#2278)
fc8ff52 

Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request May 17, 2024
@csviri
feat: use ssa for status update by default from UpdateControl (#2278)
c94f453 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request May 21, 2024
@csviri
feat: use ssa for status update by default from UpdateControl (#2278)
17a103f 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request Jun 17, 2024
@csviri
feat: use ssa for status update by default from UpdateControl (#2278)
f563f1e 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm pushed a commit that referenced this pull request Jul 8, 2024
@csviri @metacosm
feat: use ssa for status update by default from UpdateControl (#2278)
5cdefa5 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm pushed a commit that referenced this pull request Jul 9, 2024
@csviri @metacosm
feat: use ssa for status update by default from UpdateControl (#2278)
755c3b2 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm pushed a commit that referenced this pull request Jul 12, 2024
@csviri @metacosm
feat: use ssa for status update by default from UpdateControl (#2278)
1165a6a 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request Aug 8, 2024
@csviri
feat: use ssa for status update by default from UpdateControl (#2278)
8e6a18e 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri csviri mentioned this pull request Aug 14, 2024
Merged
csviri added a commit that referenced this pull request Aug 15, 2024
@csviri
feat: use ssa for status update by default from UpdateControl (#2278)
a04136c 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm pushed a commit that referenced this pull request Aug 29, 2024
@csviri @metacosm
feat: use ssa for status update by default from UpdateControl (#2278)
a64f916 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri csviri mentioned this pull request Sep 17, 2024
Merged
csviri added a commit that referenced this pull request Sep 20, 2024
@csviri
feat: use ssa for status update by default from UpdateControl (#2278)
127469a 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm pushed a commit that referenced this pull request Oct 10, 2024
@csviri @metacosm
feat: use ssa for status update by default from UpdateControl (#2278)
07ec082 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacosm metacosm metacosm approved these changes

@adam-sandor adam-sandor Awaiting requested review from adam-sandor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Sever Side Apply to Update Status and Manage Finalizers
2 participants
@csviri @metacosm