Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: silent exception handling in managed workflows #2363

Merged
merged 2 commits into from
Apr 29, 2024
Merged

feat: silent exception handling in managed workflows #2363

merged 2 commits into from
Apr 29, 2024

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Apr 24, 2024

No description provided.

@csviri
feat: silent exception handling in managed workflows
7810552 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri csviri requested a review from metacosm April 24, 2024 10:53
@openshift-ci openshift-ci bot requested a review from adam-sandor April 24, 2024 10:53
@csviri csviri linked an issue Apr 24, 2024 that may be closed by this pull request
Workflow feature switch if we should throw aggregate exception on error. #2335
Closed
metacosm
metacosm requested changes Apr 25, 2024
View reviewed changes
operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/Workflow.java Outdated
* {@link Context#managedWorkflowAndDependentResourceContext()}. If false, the exception is thrown
* by the controller before executing the reconcile method.
*/
boolean silentExceptionHandling() default false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doc doesn't really help, in my mind. It would be better to explain why someone would use this rather than what it does. The method name might not be explicit enough either.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, was thinking on a better name, but did not come up with anything better.
Any suggestion? :)

maybe explicitExceptionHandling ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or explicitExceptionChecking ?

@csviri csviri requested a review from metacosm April 26, 2024 06:30
@metacosm
refactor: rename silentExceptionHandling -> handleExceptionsInReconciler
3a46a2e 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@csviri csviri merged commit b77905e into next Apr 29, 2024
20 checks passed
@csviri csviri deleted the workflow-throw-exception-flag branch April 29, 2024 11:41
csviri added a commit that referenced this pull request May 17, 2024
@csviri @metacosm
feat: silent exception handling in managed workflows (#2363)
d471705 

Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
csviri added a commit that referenced this pull request May 17, 2024
@csviri @metacosm
feat: silent exception handling in managed workflows (#2363)
6e2d33c 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request May 21, 2024
@csviri @metacosm
feat: silent exception handling in managed workflows (#2363)
16bb1b3 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request Jun 17, 2024
@csviri @metacosm
feat: silent exception handling in managed workflows (#2363)
f412f5f 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm added a commit that referenced this pull request Jul 8, 2024
@csviri @metacosm
feat: silent exception handling in managed workflows (#2363)
1427b0b 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm added a commit that referenced this pull request Jul 9, 2024
@csviri @metacosm
feat: silent exception handling in managed workflows (#2363)
4c37bc9 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm added a commit that referenced this pull request Jul 12, 2024
@csviri @metacosm
feat: silent exception handling in managed workflows (#2363)
62d4be8 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request Aug 8, 2024
@csviri @metacosm
feat: silent exception handling in managed workflows (#2363)
fa18a50 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri csviri mentioned this pull request Aug 14, 2024
Merged
csviri added a commit that referenced this pull request Aug 15, 2024
@csviri @metacosm
feat: silent exception handling in managed workflows (#2363)
9547300 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm added a commit that referenced this pull request Aug 29, 2024
@csviri @metacosm
feat: silent exception handling in managed workflows (#2363)
5c86a9a 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri csviri mentioned this pull request Sep 17, 2024
Merged
csviri added a commit that referenced this pull request Sep 20, 2024
@csviri @metacosm
feat: silent exception handling in managed workflows (#2363)
89b9fb8 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm added a commit that referenced this pull request Oct 10, 2024
@csviri @metacosm
feat: silent exception handling in managed workflows (#2363)
8f123b3 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacosm metacosm metacosm approved these changes

@adam-sandor adam-sandor Awaiting requested review from adam-sandor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workflow feature switch if we should throw aggregate exception on error.
2 participants
@csviri @metacosm