dev(dx): lint improvements

Author: camilamacedo86

.github/workflows/ci.yml

@@ -37,13 +37,6 @@ jobs:
     - name: Build
       run: make build
 
-    - name: Lint
-      uses: golangci/golangci-lint-action@v1
-      with:
-        # Required: the version of golangci-lint is required and must be specified
-        # without patch version: we always use the latest patch version.
-        version: v1.27
-
     - name: Test
       run: make test
 

.github/workflows/golangci-lint.yml

@@ -0,0 +1,22 @@
+name: golangci-lint
+on:
+  push:
+    tags:
+      - v*
+    branches:
+      - master
+  pull_request:
+jobs:
+  golangci:
+    name: lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v1
+        with:
+          # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
+          version: v1.29
+
+          # Optional: golangci-lint command line arguments.
+          args: --timeout 5m

Makefile

@@ -8,9 +8,12 @@ SOURCES          := $(shell find . -name '*.go' -not -path "*/vendor/*" -not -pa
 build: $(SOURCES) ## Build Test
 	go build -i -ldflags="-s -w" ./...
 
-lint: golangci-lint ## Run golint
+lint: golangci-lint ## Run golangci-lint
 	@$(GOLANGCI_LINT) run
 
+lint-fix: golangci-lint ## Run golangci lint to automatically perform fixes
+	@$(GOLANGCI_LINT) run --fix
+
 fmt: ## Run go fmt
 	@gofmt -d $(SOURCES)
 
@@ -39,7 +42,7 @@ golangci-lint:
 ifeq (, $(shell which golangci-lint))
 	@{ \
 	set -e ;\
-	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(shell go env GOPATH)/bin v1.27.0 ;\
+	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(shell go env GOPATH)/bin v1.29.0 ;\
 	}
 GOLANGCI_LINT=$(shell go env GOPATH)/bin/golangci-lint
 else