-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install Plan creation with permissions #3108
Comments
|
|
the fact that the CRBs don't exist, then do ... makes me wonder if the delete actually worked |
I don't see any mention of finalizers in the codebase so I honestly can't tell how they expected this cleanup to work ... likely a fix here is to add a finalizer to the CSV to ensure we clean up when it's deleted ... ? |
This is the code that does this cleanup but it doesn't seem like there's a finalizer in play at all - so we're really not guaranteed to have cleanup happen and it's not surprising that we flake out. Looks like the fix here is just to add one. |
Unfortunately this might be a tricky one to implement since the |
As stated, the delete does not work; it seems that unless the CSV is in a (e.g.) success state, it will not be deleted, so that will have to be looked at. By waiting until the CSV is in a success state, and then deleting, the test passes. |
Fix operator-framework#3108 Attempting to delete a CSV that is not in a terminal (e.g. Success) state fails silently (i.e. the CSV is not deleted). So, wait until the CSV is in the success state before deleting. Add logging. Signed-off-by: Todd Short <todd.short@me.com>
Fix operator-framework#3108 The Subscription needs to be deleted before deleting the CSV, otherwise the Subscription will recreate the CSV, and subsequently, the CR/CRBs are not deleted. Update some test logging as well. Signed-off-by: Todd Short <todd.short@me.com>
Fix operator-framework#3108 The Subscription needs to be deleted before deleting the CSV, otherwise the Subscription will recreate the CSV, and subsequently, the CR/CRBs are not deleted. Update some test logging as well. Signed-off-by: Todd Short <todd.short@me.com>
Fix #3108 The Subscription needs to be deleted before deleting the CSV, otherwise the Subscription will recreate the CSV, and subsequently, the CR/CRBs are not deleted. Update some test logging as well. Signed-off-by: Todd Short <todd.short@me.com>
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_operator-framework-olm/606/pull-ci-openshift-operator-framework-olm-master-e2e-gcp-olm/1724082802661527552
The text was updated successfully, but these errors were encountered: