Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let net.Listen pick a port for grpc servers generated in tests #2310

Merged

Conversation

ecordell
Copy link
Member

@ecordell ecordell commented Jul 30, 2021

Description of the change:
Let net.Listen pick the port for test grpc servers. This seems to avoid issues where the ports are not freed in time for subsequent tests.

Motivation for the change:
This maybe fixes #2092, though I was unable to reproduce it locally (prior to the change in this PR, I had trouble running this test at all locally)

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive

Signed-off-by: Evan <cordell.evan@gmail.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2021
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 31, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dinhxuanvu
Copy link
Member

Interesting. We have the csv-role already exists flake and now it seems with this PR we have csv-rolebinding already exists flake.

@timflannagan
Copy link
Contributor

That should've been fixed in the previous PR - I wonder if we're simply testing out-of-date content on a per-PR basis? Was this PR rebased against the previous one, or was that other flake PR merged in parallel while this one was opened?

@openshift-ci openshift-ci bot merged commit 44fc44d into operator-framework:master Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flake: TestConnectionEvents deadlock?
3 participants