Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Clarify community vs upstream-community OperatorSources #157

Merged
merged 1 commit into from
Apr 23, 2019
Merged

[docs] Clarify community vs upstream-community OperatorSources #157

merged 1 commit into from
Apr 23, 2019

Conversation

aravindhp
Copy link
Member

@aravindhp aravindhp commented Apr 4, 2019 •
edited
Loading

  • Add a note to call out to not install both community and upstream-community OperatorSources on the same cluster
  • Move upstream-community-operators OperatorSource to deploy/upstream/

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 4, 2019
@aravindhp
Copy link
Member Author

/cc @anik120 @jeremylinlin @awgreene @galletti94

jeremy-wl
jeremy-wl approved these changes Apr 4, 2019
View reviewed changes
Copy link
Member

@jeremy-wl jeremy-wl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2019
gallettilance
gallettilance reviewed Apr 4, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
kevinrizza
kevinrizza requested changes Apr 4, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
@aravindhp
Copy link
Member Author

/lgtm cancel

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2019
@aravindhp
Copy link
Member Author

/approve cancel

@openshift-ci-robot openshift-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2019
@aravindhp aravindhp force-pushed the fix-readme-community-operators branch 2 times, most recently from 3e87ae0 to 799993e Compare April 4, 2019 17:12
@kevinrizza
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2019
@tkashem
Copy link
Collaborator

tkashem commented Apr 4, 2019

/lgtm

@kevinrizza
Copy link
Member

@aravindhp actually there is a typo in your commit message:

both community and upstrea-community

should be

both community and upstream-community

@aravindhp
Copy link
Member Author

Good catch @kevinrizza. Please request a change so that I don't forget to fix it.

kevinrizza
kevinrizza requested changes Apr 10, 2019
View reviewed changes
Copy link
Member

@kevinrizza kevinrizza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix typo in commit message.

@aravindhp
Copy link
Member Author

/approve cancel

@openshift-ci-robot openshift-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2019
@aravindhp aravindhp force-pushed the fix-readme-community-operators branch from 06244ba to e4f6c95 Compare April 22, 2019 19:45
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2019
@aravindhp
Copy link
Member Author

@awgreene I have addressed your comments. Please review.

@kevinrizza @tkashem please review.

@aravindhp
Copy link
Member Author

/test e2e-aws-operator

SamiSousa
SamiSousa reviewed Apr 22, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
SamiSousa
SamiSousa suggested changes Apr 22, 2019
View reviewed changes
Copy link
Contributor

@SamiSousa SamiSousa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the upstream operator source path

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@aravindhp aravindhp force-pushed the fix-readme-community-operators branch from e4f6c95 to 47d68bd Compare April 23, 2019 14:28
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 23, 2019
@aravindhp aravindhp force-pushed the fix-readme-community-operators branch 3 times, most recently from fc9f785 to 70a7713 Compare April 23, 2019 14:34
gallettilance
gallettilance approved these changes Apr 23, 2019
View reviewed changes
Copy link
Member

@gallettilance gallettilance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

README.md Show resolved Hide resolved
awgreene
awgreene requested changes Apr 23, 2019
View reviewed changes
Copy link
Member

@awgreene awgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good minus a bug in one of the example commands.

README.md Outdated Show resolved Hide resolved
@aravindhp
[docs] Clarify community vs upstream-community OperatorSources
b0c49e6 
- Add a note to call out to not install both community and
upstream-community OperatorSources on the same cluster
- Move upstream-community-operators OperatorSource to
deploy/upstream/
@aravindhp aravindhp force-pushed the fix-readme-community-operators branch from 70a7713 to b0c49e6 Compare April 23, 2019 14:43
@tkashem
Copy link
Collaborator

tkashem commented Apr 23, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2019
@awgreene
Copy link
Member

Looks good @aravindhp

@kevinrizza
Copy link
Member

/lgtm

@aravindhp
Copy link
Member Author

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2019
@SamiSousa
Copy link
Contributor

Looks good!

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aravindhp, galletti94, jeremylinlin, kevinrizza, SamiSousa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aravindhp
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 9009849 into operator-framework:master Apr 23, 2019
@Rajpratik71 Rajpratik71 mentioned this pull request Jan 28, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awgreene awgreene awgreene requested changes

@kevinrizza kevinrizza kevinrizza approved these changes

@SamiSousa SamiSousa SamiSousa approved these changes

@jeremy-wl jeremy-wl jeremy-wl approved these changes

@gallettilance gallettilance gallettilance approved these changes

@tkashem tkashem Awaiting requested review from tkashem

@anik120 anik120 Awaiting requested review from anik120

Assignees

@kevinrizza kevinrizza

@tkashem tkashem

@jeremy-wl jeremy-wl

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.