Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version command #1171

Merged
merged 4 commits into from
Mar 20, 2019
Merged

Version command #1171

merged 4 commits into from
Mar 20, 2019

Conversation

Avni-Sharma
Copy link
Contributor

@Avni-Sharma Avni-Sharma commented Mar 5, 2019 •
edited

Fixes #1165

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 5, 2019
@openshift-ci-robot
Copy link

Hi @Avni-Sharma. Thanks for your PR.

I'm waiting for a operator-framework or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AlexNPavel
Copy link
Contributor

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 5, 2019
AlexNPavel
AlexNPavel approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@AlexNPavel AlexNPavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexNPavel
Copy link
Contributor

/cc @hasbro17

joelanford
joelanford requested changes Mar 5, 2019
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use 2019 for the copyright year since this is a new file. Also, one other nit.

commands/operator-sdk/cmd/version.go Outdated
@@ -0,0 +1,34 @@
// Copyright 2018 The Operator-SDK Authors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Copyright 2018 The Operator-SDK Authors
// Copyright 2019 The Operator-SDK Authors

commands/operator-sdk/cmd/version.go Outdated
func NewVersionCmd() *cobra.Command {
versionCmd := &cobra.Command{
Use: "version",
Short: "Provides version of the operator-sdk",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

Suggested change
Short: "Provides version of the operator-sdk",
Short: "Prints the version of operator-sdk",

@Avni-Sharma
Copy link
Contributor Author

Avni-Sharma commented Mar 6, 2019 •
edited

I am a bit confused with Travis CI here. Few moments back it showed all the tests to have been passed.
image
cc @joelanford

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 6, 2019
lilic
lilic suggested changes Mar 6, 2019
View reviewed changes
Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Avni-Sharma do you mind rebasing again, it seems your rebase includes one of my commits merged into master recently.

Otherwise lgtm, thanks!

@cwilkers cwilkers mentioned this pull request Mar 6, 2019
Closed
@hasbro17
Copy link
Contributor

hasbro17 commented Mar 8, 2019

@Avni-Sharma Besides rebasing from master to remove the extra commits, you will also need to add a line to the Added section of the CHANGELOG and mention this change.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 11, 2019
@Avni-Sharma
Copy link
Contributor Author

Hi @hasbro17 . Made the suggested changes

joelanford
joelanford approved these changes Mar 12, 2019
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lilic
lilic approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! lgtm

@lilic
Copy link
Member

lilic commented Mar 20, 2019

cc @hasbro17 if you want to have another look, otherwise we can merge this?

hasbro17
hasbro17 approved these changes Mar 20, 2019
View reviewed changes
Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hasbro17 hasbro17 merged commit 4411f50 into operator-framework:master Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford approved these changes

@AlexNPavel AlexNPavel AlexNPavel approved these changes

@lilic lilic lilic approved these changes

@hasbro17 hasbro17 hasbro17 approved these changes

@theishshah theishshah Awaiting requested review from theishshah

Assignees
No one assigned
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Avni-Sharma @openshift-ci-robot @AlexNPavel @hasbro17 @lilic @joelanford