Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: document mercurial dependency for v0.9+ operators #1683

Merged
merged 2 commits into from
Jul 16, 2019

Conversation

estroz
Copy link
Member

@estroz estroz commented Jul 16, 2019

Description of the change: document new mercurial compile-time dependency for new operators.

Motivation for the change: new operators require mercurial be installed as of v0.9.0.

Closes #1681

@estroz estroz added the area/dependency Issues or PRs related to dependency changes label Jul 16, 2019
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 16, 2019
Copy link
Contributor

@robszumski robszumski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@AlexNPavel AlexNPavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estroz
Copy link
Member Author

estroz commented Jul 16, 2019

/test e2e-aws-ansible
/test e2e-aws-helm

@lilic
Copy link
Member

lilic commented Jul 16, 2019

Should this go in the 0.9.0 branch as well?

Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2019
@estroz
Copy link
Member Author

estroz commented Jul 16, 2019

@lilic yep, making that PR once this is merged.

@estroz estroz merged commit 21668fa into operator-framework:master Jul 16, 2019
@estroz estroz deleted the doc-mercurial-operators branch July 16, 2019 19:27
@estroz estroz restored the doc-mercurial-operators branch July 16, 2019 19:27
estroz added a commit to estroz/operator-sdk that referenced this pull request Jul 16, 2019
…ork#1683)

* README.md,doc/user-guide.md: add mercurial v3.9+ dependency for new operator projects

* CHANGELOG.md: add mercurial documentation addition
estroz added a commit that referenced this pull request Jul 16, 2019
* README.md,doc/user-guide.md: add mercurial v3.9+ dependency for new operator projects

* CHANGELOG.md: add mercurial documentation addition
@estroz estroz deleted the doc-mercurial-operators branch April 1, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Issues or PRs related to dependency changes lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mercurial prerequisite missing - release 0.9
5 participants