Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ansible): invalid maxArtifacts annotation #2093

Merged
merged 1 commit into from
Oct 25, 2019
Merged

fix(ansible): invalid maxArtifacts annotation #2093

merged 1 commit into from
Oct 25, 2019

Conversation

djzager
Copy link
Contributor

@djzager djzager commented Oct 22, 2019

When the maxArtifacts annotation can not be converted to an integer, do
not use it.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 22, 2019
@joelanford joelanford added language/ansible Issue is related to an Ansible operator project kind/bug Categorizes issue or PR as related to a bug. labels Oct 22, 2019
@joelanford
Copy link
Member

@djzager Since this is a bugfix, can you also update the CHANGELOG?

@joelanford
Copy link
Member

/test e2e-aws-subcommand

joelanford
joelanford approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @djzager!

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2019
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2019
@djzager
Copy link
Contributor Author

djzager commented Oct 23, 2019

/retest

1 similar comment
@djzager
Copy link
Contributor Author

djzager commented Oct 23, 2019

/retest

@djzager
fix(ansible): invalid maxArtifacts annotation
54da7b9 
When the maxArtifacts annotation can not be converted to an integer, do
not use it.
@djzager
Copy link
Contributor Author

djzager commented Oct 24, 2019

@joelanford updated changelog. Let me know if you need anything else.

camilamacedo86
camilamacedo86 approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 it shows great.

/lgtm
/approved

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2019
@camilamacedo86 camilamacedo86 added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2019
@fabianvf fabianvf merged commit 5eeb1f3 into operator-framework:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@joelanford joelanford joelanford approved these changes

@fabianvf fabianvf Awaiting requested review from fabianvf

@jmrodri jmrodri Awaiting requested review from jmrodri

Assignees

@joelanford joelanford

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. language/ansible Issue is related to an Ansible operator project lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@djzager @joelanford @camilamacedo86 @fabianvf @openshift-ci-robot