Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible: Support vars in watches #2147

Merged
merged 1 commit into from
Nov 6, 2019

Conversation

Jamstah
Copy link
Contributor

@Jamstah Jamstah commented Nov 2, 2019

Description of the change:
Support for vars in the top level of ansible watches

Motivation for the change:
Ability to use one playbook for multiple watches with different vars

Closes #2138

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 2, 2019
@openshift-ci-robot
Copy link

Hi @Jamstah. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 2, 2019
This adds support for extra vars in top level watches for ansible, to allow for the same playbook to be used for multiple GVKs with different vars.

Fixes operator-framework#2138
@Jamstah Jamstah changed the title Support vars in watches ansible: Support vars in watches Nov 3, 2019
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Jamstah,

Really thank you for your contribution 🥇 . It shows attending all requirements(has a changelog, has tests implemented and it has the docs updates). Well done 👍

@fabianvf wdyt?

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 5, 2019
@Jamstah
Copy link
Contributor Author

Jamstah commented Nov 5, 2019

/test e2e-aws-helm

Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it is : /lgtm /approved
However, in order to merge this one is required to get the review/input of the others in the team as well.
@fabianvf @jmrodri wdyt?

Copy link
Member

@fabianvf fabianvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2019
@camilamacedo86 camilamacedo86 merged commit bad0ca5 into operator-framework:master Nov 6, 2019
@Jamstah Jamstah deleted the ansible-vars branch November 7, 2019 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add vars support to ansible watches
4 participants