pkg/test/e2eutil: wait for a deployment to have >= n replicas #2248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
dustinspecker
force-pushed
the
fix-wait-for-deployment
branch
from
6b028cf
to
30714a9
Compare
Sorry about that - I've added it now. |
CHANGELOG.md
Outdated
| @@ -11,6 +11,7 @@ | |||
| ### Removed | |||
|
|
|||
| ### Bug Fixes | |||
| - WaitForDeployment and WaitForOperatorDeployment from pkg/test/e2eutil successfully complete waiting when the available replica count is greater than the minimum replica count required. ([#2248](https://github.com/operator-framework/operator-sdk/pull/2248)) | |||
There was a problem hiding this comment.
Suggested change
| - WaitForDeployment and WaitForOperatorDeployment from pkg/test/e2eutil successfully complete waiting when the available replica count is greater than the minimum replica count required. ([#2248](https://github.com/operator-framework/operator-sdk/pull/2248)) | |
| - Fix `WaitForDeployment` and `WaitForOperatorDeployment` from`pkg/test/e2eutil` successfully complete waiting when the available replica count is equals or greater than the minimum replica count required. ([#2248](https://github.com/operator-framework/operator-sdk/pull/2248)) |
There was a problem hiding this comment.
I'm not sure this is a bug fix. Seems more like a change/improvement to me.
Also to build on @camilamacedo86's suggestion, WDYT of this for the CHANGELOG line:
Suggested change
| - WaitForDeployment and WaitForOperatorDeployment from pkg/test/e2eutil successfully complete waiting when the available replica count is greater than the minimum replica count required. ([#2248](https://github.com/operator-framework/operator-sdk/pull/2248)) | |
| - Updated `pkg/test/e2eutil.WaitForDeployment()` and `pkg/test/e2eutil.WaitForOperatorDeployment()` to successfully complete waiting when the available replica count is _at least_ (rather then exactly) the minimum replica count required. ([#2248](https://github.com/operator-framework/operator-sdk/pull/2248)) |
There was a problem hiding this comment.
That sounds good to me. I've updated the changelog. Thank you both for the help!
camilamacedo86
previously approved these changes
Nov 21, 2019
dustinspecker
force-pushed
the
fix-wait-for-deployment
branch
from
30714a9
to
77e897e
Compare
camilamacedo86
dismissed
their stale review
Shows that after this change the asserts are not working well for ansible. See skipping: [localhost] => {"changed": false, "skip_reason": "Conditional result was False"}
camilamacedo86
approved these changes
Nov 21, 2019
camilamacedo86
added
approved
JAORMX
approved these changes
Nov 22, 2019
Before waitForDeployment was waiting until the exact number of replicas were available. Now, wait for at least that number of replicas to be available. scenario: I'm using an operator with 3 replicas, but only 1 is needed for tests to work. If all 3 replicas were available before waitForDeployment started then it would wait until it timed out because 3 does not equal 1. Now, since 3 replicas is greater than the 1 needed for tests waitForDeployment successfully waits.
dustinspecker
force-pushed
the
fix-wait-for-deployment
branch
from
77e897e
to
c5597bd
Compare
camilamacedo86
approved these changes
Nov 25, 2019
There was a problem hiding this comment.
/lgtm /approved
@joelanford are you ok with merge this one now? WDYT?
estroz
approved these changes
Nov 25, 2019
estroz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before waitForDeployment was waiting until the exact number of replicas
were available. Now, wait for at least that number of replicas to be
available.
scenario:
I'm using an operator with 3 replicas, but only 1 is needed for tests to
work. If all 3 replicas were available before waitForDeployment started
then it would wait until it timed out because 3 does not equal 1. Now,
since 3 replicas is greater than the 1 needed for tests waitForDeployment
successfully waits.