*: add kube apply action #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hongchaodeng @fanminshi PTAL |
pkg/sdk/informer/sync.go
Outdated
| object, err := k8sutil.RuntimeObjectFromUnstructured(unstructObj) | ||
| if err != nil { | ||
| logrus.Errorf("failed to get runtime object from unstructured: %v", err) | ||
| panic(err) |
There was a problem hiding this comment.
If the unstructured could not convert to runtime object, it seems like we can't handle it anyway. Why not just panic inside the method?
|
LGTM after nit |
fanminshi
reviewed
Feb 26, 2018
pkg/sdk/action/action.go
Outdated
| return nil | ||
| } | ||
|
|
||
| // KubeApply will try to create the specified object or update it if it already exists |
There was a problem hiding this comment.
KubeApply will try to create -> KubeApply tries to create?
|
lgtm after a small suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part [1/2] of #57
Added implementation for
kube apply.For the resourceVersion conflict case the only thing to do would be to fail the action, which would re-queue the key, retry the sync, and the Handler. The expectation is that calling Handle() again would give us an Action with the latest object.