Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ansible: support disabling reconciliation #739

Merged
merged 3 commits into from
Nov 13, 2018
Merged

ansible: support disabling reconciliation #739

merged 3 commits into from
Nov 13, 2018

Conversation

djzager
Copy link
Contributor

@djzager djzager commented Nov 13, 2018

  • Enforce the "default" reconcilePeriod to be > 0
  • Enforce reconcilePeriod for a particular GVK to be >= 0

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 13, 2018
@openshift-ci-robot
Copy link

Hi @djzager. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 13, 2018
@djzager
ansible: support disabling reconciliation
bd5d1ca 
- Remove duration check from controller
- Use pointer to time.Duration and check for nil from watches
@shawn-hurley shawn-hurley self-requested a review November 13, 2018 18:26
@shawn-hurley shawn-hurley added the language/ansible Issue is related to an Ansible operator project label Nov 13, 2018
@shawn-hurley
Copy link
Member

LGTM, thanks for updating the test as well.

@fabianvf @dymurray can you guys take a look as well?

dymurray
dymurray approved these changes Nov 13, 2018
View reviewed changes
Copy link
Contributor

@dymurray dymurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice job on tests.

shawn-hurley
shawn-hurley approved these changes Nov 13, 2018
View reviewed changes
Copy link
Member

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shawn-hurley shawn-hurley merged commit 675fb6e into operator-framework:master Nov 13, 2018
@djzager djzager deleted the f-reconcile branch November 13, 2018 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dymurray dymurray dymurray approved these changes

@shawn-hurley shawn-hurley shawn-hurley approved these changes

Assignees
No one assigned
Labels
language/ansible Issue is related to an Ansible operator project needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@djzager @openshift-ci-robot @shawn-hurley @dymurray