Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/scaffold/,commands/operator-sdk/cmd/new.go: use chart values in CR spec #967

Merged
merged 5 commits into from
Jan 30, 2019
Merged

pkg/scaffold/,commands/operator-sdk/cmd/new.go: use chart values in CR spec #967

merged 5 commits into from
Jan 30, 2019

Conversation

joelanford
Copy link
Member

@joelanford joelanford commented Jan 21, 2019 •
edited
Loading

Description of the change:

  1. Adds support in CR scaffold for custom specs
  2. Updates scaffolding of Helm project to inject default chart values into the CR spec.

Motivation for the change:

  1. When a new Helm project is created, we currently hard-code size: 3 in the CR spec, which is not applicable in the default chart that gets generated.
  2. Operator developers will be able to see the set of values that are applicable to the chart when editting the CR.

Closes #838

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 21, 2019
estroz
estroz approved these changes Jan 22, 2019
View reviewed changes
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @joelanford does this close #838? Also I think this is a step towards a feature like that mentioned in #877.

@joelanford
Copy link
Member Author

@estroz Yes, good catch. This will close #838. I'll add that to the description.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2019
shawn-hurley
shawn-hurley approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joelanford joelanford merged commit c1c946e into operator-framework:master Jan 30, 2019
@joelanford joelanford deleted the helm-cr-scaffold branch January 30, 2019 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estroz estroz estroz approved these changes

@shawn-hurley shawn-hurley shawn-hurley approved these changes

@hasbro17 hasbro17 Awaiting requested review from hasbro17

@AlexNPavel AlexNPavel Awaiting requested review from AlexNPavel

@lilic lilic Awaiting requested review from lilic

@mhrivnak mhrivnak Awaiting requested review from mhrivnak

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joelanford @shawn-hurley @estroz @openshift-ci-robot