Fix/help text bugs (#5745)

* [25778] Sort available help attributes

* [25799] Use proc for inclusion check

Otherwise, that value is never re-evaluated. A newly created CF
will fail to be found.

https://community.openproject.com/wp/25779/

* [25780] Remove paragraph signs in headings of help text modal

* [25781] Overflow help text modal after 50vh

* [25782] Add ellipsis to modal header


[ci skip]

app/assets/stylesheets/content/_help_texts.sass

@@ -27,12 +27,26 @@
 //++
 
 .attribute-help-text--modal
+  // Set max width of the attribute heading
+  .modal--header > h2
+    width: calc(100% - 80px)
+
   .modal--footer
     text-align: left
     display: flex
     justify-content: space-between
 
+  // Set max height of the modal body
+  .modal--main
+    max-height: 50vh
+    overflow-y: auto
+
   // Avoid large right margin for conditional button
   .help-text--edit-button
     margin-right: 0
 
+  // Hide the wiki-anchor
+  .wiki-anchor,
+  *:hover .wiki-anchor
+    display: none
+

app/helpers/attribute_help_texts_helper.rb

@@ -22,7 +22,7 @@
 # GNU General Public License for more details.
 #
 # You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
+# along with this program::Type.translated_work_package_form_attributes; if not, write to the Free Software
 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
 #
 # See doc/COPYRIGHT.rdoc for more details.
@@ -33,7 +33,9 @@ def selectable_attributes(instance)
     available = instance.class.available_attributes
     used = AttributeHelpText.used_attributes(instance.type)
 
-    available.reject! { |k,| used.include? k }
-    available.map { |k, v| [v, k] }
+    available
+      .reject { |key,| used.include? key }
+      .map { |key, label| [label, key] }
+      .sort_by { |label, key| label.downcase }
   end
 end

app/models/attribute_help_text/work_package.rb

@@ -9,7 +9,7 @@ def self.available_attributes
     attributes
   end
 
-  validates_inclusion_of :attribute_name, in: available_attributes.keys
+  validates_inclusion_of :attribute_name, in: ->(*) { available_attributes.keys }
 
   def attribute_scope
     'WorkPackage'

frontend/app/components/common/help-texts/help-text.modal.html

@@ -2,7 +2,7 @@
   <div>
     <div class="modal--header">
       <span class="icon-context icon-help2"></span>
-      <h2 ng-bind="::resource.attributeCaption"></h2>
+      <h2 class="ellipsis" ng-bind="::resource.attributeCaption"></h2>
     </div>
 
     <div class="modal--main"