Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate run-shellcheck.sh #93

Closed
seroyer opened this issue Jul 11, 2022 · 2 comments · Fixed by #95
Closed

Deduplicate run-shellcheck.sh #93

seroyer opened this issue Jul 11, 2022 · 2 comments · Fixed by #95
Assignees
@mestery
Labels
good first issue Good for newcomers

Comments

@seroyer
Copy link
Contributor

seroyer commented Jul 11, 2022

There are currently 3 identical versions of this file in the repo:
integration/scripts/run-shellcheck.sh
networking/scripts/run-shellcheck.sh
storage/scripts/run-shellcheck.sh
@mestery mestery added the good first issue Good for newcomers label Jul 11, 2022
@mestery
Copy link
Contributor

mestery commented Jul 11, 2022

I agree, and easy fix!

@mestery mestery self-assigned this Jul 11, 2022
@mestery
Copy link
Contributor

mestery commented Jul 11, 2022

I'll take this one and do it while in calls this afternoon.

mestery added a commit to mestery/opi-poc that referenced this issue Jul 11, 2022
@mestery
shellcheck: Use one run-shellcheck.sh script
8b8a899 
This moves the shellcheck script into a common location.

Closes opiproject#93

Signed-off-by: Kyle Mestery <mestery@mestery.com>
@mestery mestery mentioned this issue Jul 11, 2022
Merged
mestery added a commit that referenced this issue Jul 11, 2022
@mestery
shellcheck: Use one run-shellcheck.sh script
7130d1c 
This moves the shellcheck script into a common location.

Closes #93

Signed-off-by: Kyle Mestery <mestery@mestery.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mestery mestery

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

shellcheck: Use one run-shellcheck.sh script mestery/opi-poc
2 participants
@mestery @seroyer